Skip to content

Conversation

@gabecano4308
Copy link
Contributor

@gabecano4308 gabecano4308 commented Jul 8, 2025

Adding rest of external input validators

Checklist:

Before submitting your PR, please confirm that you have done the following:

  • I have opened my PR against the staging branch, NOT against main
  • I've run the relevant formatting and linting tools listed in the setup docs
  • I have commented hard-to-understand areas in my code
  • I've reviewed any merge conflicts to make sure they are resolved
  • My changes generate no new warnings

Description

Input validators are added according to the tables listed by Nissim in the issue comments. I added a row count helper function in the base.py file and call it to ensure rows per table are within expected tolerance. Input validators also check that the columns used downstream are present and of the appropriate type.

Related Issue(s)

This PR addresses issue #1224

Type of change

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

I've ran the pipeline with print statements to ensure flags are happening as expected and no new warnings are generated.

@vercel
Copy link

vercel bot commented Jul 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2025 6:56pm

@nlebovits nlebovits merged commit af94616 into CodeForPhilly:staging Jul 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants